Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration via GitHub Actions. #1

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

jdumas
Copy link
Contributor

@jdumas jdumas commented Feb 28, 2022

  • Adds a PR check + nightly job via GitHub Actions.
  • Runs on Windows/macOS/Linux. Currently missing: Android, Emscripten, MinGW and Linux-ICC
  • Currently no unit tests are run. Not sure what you want to do there?

To facilitate CMake maintenance, I'd recommend the following:

  • Get rid of configure.sh and configure.bat. Platforms can be detected directly via CMake (see new file geo_detect_platform.cmake.
  • There are a lot of files in cmake/platforms.cmake, which seems like a pain to maintain. I'd recommend keeping a single platforms/Windows.cmake and a single platforms/Unix.cmake and use check_cxx_compiler_flag to check for compiler support for specific flags across all possible GCC/clang versions.

Continuous PR check:
Screen Shot 2022-02-27 at 6 23 10 PM

Nightly check:
Screen Shot 2022-02-27 at 5 59 34 PM

@BrunoLevy
Copy link
Owner

Fantastic Jeremie !
To make it clear, if I merge this pull request, it will start continuous integration directly ? There is nothing else to configure ?

@jdumas
Copy link
Contributor Author

jdumas commented Feb 28, 2022

Yes I believe so. In the repo setting page you have some options related to github actions. By default it will require you to "approve" first-time contributors before running any action coming from a fork pull request.

@BrunoLevy BrunoLevy merged commit db70316 into BrunoLevy:main Feb 28, 2022
@jdumas jdumas deleted the jdumas/actions branch February 28, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants