RFC: Initial pass at a CODEOWNERS #458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Modification by reviews can be done directly to branch after discussion here or in Matrix, avoiding additional noise from shifting things, adding or removing entries, etc. |
|
Noticed missing language / words in original commit message. Updated to reflect it is not intend to enforce / mandate blockers, and uses common SHOULD / SHOULD NOT / NOT / WILL language you typically see in other RFCs or specs. |
serebit
approved these changes
Sep 30, 2023
This pull request is an RFC to adds codeowner defaults for various parts of the codebase, based on historical or regular contributions. It is intended to be used to enforce or mandate blocking individuals for merge. Listings can / should be modified based on interest / desire for code reviews, not necessarily considered exhaustive. All listings have an addition of the Best Buds team, so anyone on the team should be notified automatically. Global rule notifies the Best Buds team as well.
JoshStrobl
force-pushed
the
add-codeowners
branch
from
d5ef307 to
28ace40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an RFC to adds codeowner defaults for various parts of the codebase, based on historical or regular contributions. It is NOT intended to be used to enforce or mandate blocking individuals for merge. Listings can / SHOULD be modified based on interest / desire for code reviews, and SHOULD NOT be considered exhaustive.
All listings have an addition of the Best Buds team, so anyone on the team WILL be notified automatically. Global rule notifies the Best Buds team as well.