Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to xf4w v4.19.8 #630

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Adapt to xf4w v4.19.8 #630

merged 5 commits into from
Nov 11, 2024

Conversation

fossfreedom
Copy link
Contributor

@fossfreedom fossfreedom commented Oct 20, 2024

Description

This PR adapts the main branch to support libxfce4windows v4.19.8

In addition it removes from budgie-daemon the use of libwnck; this stops magpie/labwc from crashing on login.

Note - I'll do a separate PR to generate xfw vapi correctly - for the moment it is slightly tweaked after vapigen to remove some ccode nonsense
This PR now generates the vapi without additional hacking

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

@fossfreedom fossfreedom changed the title Adapt to xf4w v4.19.7 Adapt to xf4w v4.19.8 Oct 27, 2024
@EbonJaeger EbonJaeger mentioned this pull request Oct 28, 2024
2 tasks
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I have access to the latest XFCE stuff, I have been able to test this. Everything seems to work just fine. I've switched between open windows via the tasklist and the Alt+Tab interface without issue.

Copy link
Member

@JoshStrobl JoshStrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JoshStrobl JoshStrobl merged commit a23ff6a into main Nov 11, 2024
1 check failed
@JoshStrobl JoshStrobl deleted the xfwvapi branch November 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants