Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation fixes #15081

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Automation fixes #15081

merged 7 commits into from
Dec 9, 2024

Conversation

deanhannigan
Copy link
Contributor

@deanhannigan deanhannigan commented Nov 28, 2024

Description

This addresses some general automation issues:

  • The recent race condition fix inadvertently caused another issue, where the Test Modal would appear to clear on blur. This has now been resolved
  • During testing, I saw that for row automation triggers like, Row Updated, the test config would be reset if you didn't add any fields at all. This was because the default config values were initially ignored even though they were correctly initialised.

Addresses

Copy link

qa-wolf bot commented Nov 28, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deanhannigan deanhannigan merged commit 3af9db3 into master Dec 9, 2024
19 checks passed
@deanhannigan deanhannigan deleted the automations-fixes branch December 9, 2024 11:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values are not passed correct in the automation test screen
2 participants