Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MySQL options column imports that have commas or other type names in them. #15106

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Dec 3, 2024

Description

We had a user reporting that their enum columns weren't being imported correctly. On investigation, I found 2 separate bugs with enum imports in MySQL:

  • We weren't correctly parsing commas in enum fields, so enum variants containing commas could break it.
  • We were incorrectly checking enum variants to see if they were type names, confusing the heuristics that determine what Budibase type to assign to a field.

This PR fixes both and adds tests to prevent regression.

Launchcontrol

  • Fixes some bugs around importing tables that have enum column where the enum variants contain commas or type names.

@samwho samwho requested a review from a team as a code owner December 3, 2024 12:14
@samwho samwho requested review from mike12345567 and removed request for a team December 3, 2024 12:14
Copy link

qa-wolf bot commented Dec 3, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/l labels Dec 3, 2024
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for quick fix

@samwho samwho enabled auto-merge December 3, 2024 12:23
@samwho samwho merged commit 07b5dc6 into master Dec 3, 2024
19 checks passed
@samwho samwho deleted the fix-options-with-commas-and-types branch December 3, 2024 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants