feat[angular-gen2]: A/B tests support #3898
Conversation
🦋 Changeset detectedLatest commit: 1441004 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 1441004.
☁️ Nx Cloud last updated this comment at |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9071768 | Triggered | Generic High Entropy Secret | 064d947 | packages/sdks-tests/src/specs/video-lazy-load.ts | View secret |
| 9071769 | Triggered | Generic High Entropy Secret | 064d947 | packages/sdks-tests/src/specs/video-lazy-load.ts | View secret |
| 11707119 | Triggered | Generic High Entropy Secret | 064d947 | packages/sdks/snippets/react/src/routes/LivePreviewBlogData.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
| @@ -150,6 +150,33 @@ test.describe('Visual Editing', () => { | |||
| } | |||
| }); | |||
|
|
|||
| test('removal of styles should work properly', async ({ page, packageName, sdk, basePort }) => { | |||
There was a problem hiding this comment.
ran the test on main branch as well and it was failing so we can be sure that styles now work as expected,
Description
Jira
https://builder-io.atlassian.net/browse/ENG-8217
https://builder-io.atlassian.net/browse/ENG-8383
Looms
https://www.loom.com/share/93a87a08e48f468180f9110bb434aa4c
https://www.loom.com/share/035299b7d96149b78f2f31bb42be7804