-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate Limiting, Max Concurrency, Infinite Crawl & Additional Configurations #102
Open
cpdata
wants to merge
14
commits into
BuilderIO:main
Choose a base branch
from
cpdata:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dbb6a21
Add VSCode workspace file in .gitignore
cpdata 60ec188
Add outputs dir to .gitignore for final outputs
cpdata 14eb9fa
Add Dynamic OutputFileName based on date-timestamp
cpdata e700f6e
Allow maxPagesToCrawl to be optional and infinite by setting 0 which …
cpdata ac0ac25
Added maxConcurrency config to set maximum concurrent parallel requests.
cpdata a6b4b1f
Update to core.ts for maxPagesToCrawl
cpdata c6b6303
Addded headless mode as a configuration parameter
cpdata b427b25
Added waitPerPageCrawlTimeoutRange for a random range in milliseconds…
cpdata 35ea95b
Added ts-ignore for docker config.ts to prevent VSCode from declaring…
cpdata a996ab1
Added Output Directory for all outputFileName to go into so they aren…
cpdata 33faaf5
Additions to dynamic url and match configurations in config.ts
cpdata 83a5b0c
Added waitForSelectorTimeout to README.md
cpdata 401fa9b
Adding details to README.md and config.ts as well as extra formatting.
cpdata 62521b7
Update prettier formatting for README.md, src/config.ts, src/core.ts,…
cpdata File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# Ignore artifacts | ||
|
||
node_modules | ||
.github | ||
storage | ||
outputs | ||
*.code-workspace | ||
|
||
## This file tells which files shouldn't be added to source control | ||
|
||
.idea | ||
dist | ||
node_modules | ||
apify_storage | ||
crawlee_storage | ||
storage | ||
.DS_Store | ||
|
||
## any output from the crawler | ||
|
||
*.json | ||
pnpm-lock.yaml | ||
|
||
## Final ouputs folder | ||
|
||
outputs | ||
|
||
## VS Code workspace files | ||
|
||
*.code-workspace |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,33 @@ | ||
import { Config } from "./src/config"; | ||
import { fileURLToPath } from "url"; | ||
import { dirname } from "path"; | ||
|
||
const __filename = fileURLToPath(import.meta.url); | ||
const __dirname = dirname(__filename); | ||
|
||
const startingUrl = "https://www.builder.io/c/docs/developers"; | ||
const urlPrefix = "https://"; | ||
const domain = "www.builder.io"; | ||
const urlSuffix = "/c/docs"; | ||
const baseUrl = urlPrefix + domain; | ||
const matchUrl_prefix = baseUrl + urlSuffix; | ||
const matchUrl = matchUrl_prefix + "/**"; | ||
|
||
// Now date stamp for output file name | ||
const now = new Date(); | ||
const date = now.toISOString().split("T")[0]; | ||
const time = now.toTimeString().split(" ")[0]; | ||
const outputs_dir = __dirname.split("/").slice(0, -1).join("/") + "/outputs"; | ||
|
||
const outputFileName = | ||
outputs_dir + "/" + domain + "-" + date + "-" + time + ".json"; | ||
|
||
export const defaultConfig: Config = { | ||
url: "https://www.builder.io/c/docs/developers", | ||
match: "https://www.builder.io/c/docs/**", | ||
url: startingUrl, | ||
match: matchUrl, | ||
maxPagesToCrawl: 50, | ||
outputFileName: "output.json", | ||
outputFileName: outputFileName, | ||
waitPerPageCrawlTimeoutRange: { min: 1000, max: 1000 }, | ||
headless: true, | ||
maxConcurrency: 1, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
// @ts-ignore | ||
import { Config } from "./src/config"; | ||
|
||
export const defaultConfig: Config = { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cpdata! Just a couple more nitpicks (replacing snake_case for camelCase) and a rebase and we are good to go!