Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exclude pattern for links in config #122

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

cipherCOM
Copy link

See #9 for context. Simple addition to exclude with globs and regex.

@cipherCOM
Copy link
Author

@marcelovicentegc my prettier run has many more changes (only trailing commas) in the whole core.ts. So can't help with the prettier_check fail. Or I make the change bigger than it is, by reformatting the core.ts and config.ts, if this is okay with you.

@cipherCOM cipherCOM removed their assignment Dec 31, 2023
@marcelovicentegc
Copy link
Contributor

Hey @cipherCOM! Happy new years! Would you mind just rebasing this PR 🤗? This will make sure that all tests pass 😉

@cipherCOM
Copy link
Author

cipherCOM commented Jan 6, 2024

@marcelovicentegc rebased and pushed, everything okay now? :)

Happy new years to you too and have a great start into the year!

Copy link
Contributor

@marcelovicentegc marcelovicentegc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cipherCOM! LGTM 🥳

@marcelovicentegc marcelovicentegc merged commit 3cda4eb into BuilderIO:main Jan 6, 2024
4 of 5 checks passed
Copy link

github-actions bot commented Jan 6, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

hirsaeki pushed a commit to hirsaeki/gpt-crawler-y-upstream that referenced this pull request Mar 27, 2024
feat: add exclude pattern for links in config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants