-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add prettier check #88
Conversation
Nice, @kunal00000! It looks like the test workflow is broken, you might need to run |
Umm 🤔, does this workflow need to have fmt command to fix prettier issues. |
I woul
Sorry I might not have been clear! The workflow doesn't need to format any code, this step should be done on a pre-commit hook IMO (another PR). What I mean is that the prettier check is failing, so you need to run |
Ah got it. How do I do it using pre-commit hook never used it before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
chore: add prettier check
This PR is copy of #48 .
It got messed up while rebasing.
Resolves #47