Skip to content

Commit

Permalink
fix: conditions reset honors the latest timestamp of all unacked msgs (
Browse files Browse the repository at this point in the history
…argoproj#1523)

Signed-off-by: Derek Wang <[email protected]>
  • Loading branch information
whynowy authored and BulkBeing committed Mar 7, 2022
1 parent 9d267b5 commit 5deaa94
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions eventbus/driver/nats.go
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,9 @@ func (n *natsStreaming) processEventSourceMsg(m *stan.Msg, msgHolder *eventSourc
// New message, set and check
msgHolder.msgs[depName] = &eventSourceMessage{seq: m.Sequence, timestamp: m.Timestamp, event: event, lastDeliveredTime: now}
msgHolder.parameters[depName] = true
if msgHolder.latestGoodMsgTimestamp < m.Timestamp {
msgHolder.latestGoodMsgTimestamp = m.Timestamp
}

// Check if there's any stale message being held.
// Stale message could be message age has been longer than NATS streaming max message age,
Expand Down

0 comments on commit 5deaa94

Please sign in to comment.