vuln-fix: Temporary File Information Disclosure

This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh <[email protected]> Signed-off-by: Jonathan Leitschuh <[email protected]> Bug-tracker: JLLeitschuh/security-research#18 Co-authored-by: Moderne <[email protected]>
BulkSecurityGeneratorProjectV2 · Nov 18, 2022 · 0eaca11 · 0eaca11
1 parent bb53609
commit 0eaca11
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/java/org/apache/maven/plugins/install/InstallFileMojo.java b/src/main/java/org/apache/maven/plugins/install/InstallFileMojo.java
@@ -340,7 +340,7 @@ private File readingPomFromJarFile()
                         {
                             base = base.substring( 0, base.lastIndexOf( '.' ) );
                         }
-                        pomFile = File.createTempFile( base, ".pom" );
+                        pomFile = Files.createTempFile( base, ".pom" ).toFile();
 
                         pomOutputStream = Files.newOutputStream( pomFile.toPath() );
 
@@ -498,7 +498,7 @@ private File generatePomFile()
         Writer writer = null;
         try
         {
-            File pomFile = File.createTempFile( "mvninstall", ".pom" );
+            File pomFile = Files.createTempFile( "mvninstall", ".pom" ).toFile();
 
             writer = new XmlStreamWriter( pomFile );
             new MavenXpp3Writer().write( writer, model );