vuln-fix: Temporary File Information Disclosure

This fixes temporary file information disclosure vulnerability due to the use
of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by
using the `Files.createTempFile()` method which sets the correct posix permissions.

Weakness: CWE-377: Insecure Temporary File
Severity: Medium
CVSSS: 5.5
Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation)

Reported-by: Jonathan Leitschuh <[email protected]>
Signed-off-by: Jonathan Leitschuh <[email protected]>

Bug-tracker: JLLeitschuh/security-research#18


Co-authored-by: Moderne <[email protected]>

src/test/java/org/apache/maven/shared/runtime/MavenRuntimeVisitorUtilsTest.java

@@ -23,6 +23,7 @@
 import java.io.IOException;
 import java.net.URL;
 import java.net.URLClassLoader;
+import java.nio.file.Files;
 
 import junit.framework.TestCase;
 
@@ -83,7 +84,7 @@ public void testWithUnknownFileExtension() throws IOException, MavenRuntimeExcep
 
     private URL createTempFile( String prefix, String suffix ) throws IOException
     {
-        File file = File.createTempFile( prefix, suffix );
+        File file = Files.createTempFile( prefix, suffix ).toFile();
         file.deleteOnExit();
 
         return file.toURI().toURL();