Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

INREL-4059: Lazy load images in sliders (slick.js) on click / touch / drag #125

Open
wants to merge 2 commits into
base: 8.x-3.x
Choose a base branch
from
Open

INREL-4059: Lazy load images in sliders (slick.js) on click / touch / drag #125

wants to merge 2 commits into from

Conversation

alxshell
Copy link
Contributor

@alxshell alxshell commented Jun 6, 2018

@alxshell alxshell added the review label Jun 6, 2018
@alxshell alxshell self-assigned this Jun 6, 2018
@saviomuc saviomuc requested a review from Nicozilla June 7, 2018 11:16
@alxshell alxshell changed the base branch from 8.x-2.x to 8.x-3.x June 7, 2018 11:20
saviomuc
saviomuc approved these changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@saviomuc saviomuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@alxshell
Copy link
Contributor Author

Due to the fact, that following images are not loaded soon enough on mobile devices, I enhanced the offset to 300 to load the images earlier.

@Nicozilla Nicozilla removed their request for review August 28, 2018 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saviomuc saviomuc saviomuc approved these changes

Assignees

@alxshell alxshell

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxshell @saviomuc