DRPLDCX-82 Messages on dropzone #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 5, 2016 20:17
| function updateCallback(progress, status, pb) { | ||
| if (progress === '100') { | ||
| pb.stopMonitoring(); | ||
| $.ajax({ |
There was a problem hiding this comment.
This is the part I changed from the original batch.js. window.location = something would be a real showstopper
|
Funktioniert soweit gut, nur sieht es etwas komisch aus |
|
Please feel free to open a frontend refinement ticket. I'm not a frontend developer and would refrain myself from putting more time into this. If there's no technical/funcitonal issues with it, please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow visual feedback on the current state of the DC-X import via dropzone. Display messages after import.
To make make this work we need to patch core, see https://www.drupal.org/node/2781993.
The missing makefile line looks (somewhat) like this:
patch:- "https://www.drupal.org/files/issues/allow_redirect_callback_to_return-2781993-5.patch"