Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubinfo und notification #4

Merged
merged 11 commits into from
Apr 26, 2016
Merged

Conversation

goechsler
Copy link
Contributor

This provides an notification callback which trigger import of a already known DC-X image. See dcx_notification.

The route provided by dcx_notification is written to the pubinfo in JsonClient::trackUsage().

This also provides a debug module called dcx_debug_json_client which can be savely ignored because it is not as useful as expected.

@goechsler goechsler assigned goechsler and chrfritsch and unassigned goechsler Apr 26, 2016
throw new NotAcceptableHttpException($this->t('Parameter id is missing.'));
}

$id = $_GET['id'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont use the $_GET variable. Inject the request_stack and use getCurrentRequest() to get the request.

@chrfritsch chrfritsch merged commit f6e176a into 8.x-1.x Apr 26, 2016
@chrfritsch chrfritsch deleted the feature/DRPLDCX-44/pubinfo-callback branch April 26, 2016 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants