Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DnD widget in a EntityBrowser Widget #5

Merged
merged 4 commits into from
Apr 26, 2016
Merged

Move DnD widget in a EntityBrowser Widget #5

merged 4 commits into from
Apr 26, 2016

Conversation

chrfritsch
Copy link
Member

  • This moves the dnd widget in a Entity Browser Widget
  • Makes widget a bit more fancier
  • Make the DCX InDesign button work with DnD Widget

goechsler
goechsler reviewed Apr 26, 2016
View reviewed changes
modules/dcx_migration/src/Controller/UploadController.php

/**
* @file
* Contains \Drupal\dropzonejs\Controller\UploadController.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh. Nitpick!

@goechsler
Copy link
Contributor

I'd personally would prefer to have this in its own module, e.g. dcx_dropzone_widget as it's not really related to migration.
Some other observations:

  • When dropping anything in the dropzone we end up on the list (first tab of eb) without proper error message.
  • Drop of multiple images apparently not working.

@chrfritsch
Copy link
Member Author

I would prefer to move the Eb Widget to the main dcx_integration module.

goechsler
goechsler reviewed Apr 26, 2016
View reviewed changes
modules/dcx_dropzone_ui/dcx_dropzone_ui.module
/**
* Prepares variables for dropzone form element.
*
* Default template: dropzonejs.html.twig.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick. nörgel

chrfritsch
chrfritsch reviewed Apr 26, 2016
View reviewed changes
modules/dcx_dropzone_ui/js/dcx-dropzone-ui.js

if (dropzone.hasClass('is-uploading')) return false;

dropzone.addClass('is-uploading').removeClass('is-error');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary for state handling of the dropzone widget

@goechsler goechsler merged commit 3e9fb17 into 8.x-1.x Apr 26, 2016
@chrfritsch chrfritsch deleted the feature/eb_widget branch April 26, 2016 15:11
@dbosen dbosen mentioned this pull request Apr 17, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrfritsch @goechsler