Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore/types: add Windows Command Prompt files #2556

Merged
merged 1 commit into from
Jul 10, 2023
Merged

ignore/types: add Windows Command Prompt files #2556

merged 1 commit into from
Jul 10, 2023

Conversation

mataha
Copy link
Contributor

@mataha mataha commented Jul 9, 2023

This PR adds *.bat and *.cmd file types.

In doing so, it makes a distinction between batch files (old standard from the MS-DOS era) and command scripts (new flavor - can operate on batch files, although *.cmd is preferred for various reasons, the main one being batch files will set ERRORLEVEL following inconsistent MS-DOS style rules).

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to provide a source for this change? Ideally something from Microsoft's docs.

crates/ignore/src/default_types.rs Outdated Show resolved Hide resolved
@mataha
Copy link
Contributor Author

mataha commented Jul 10, 2023

Is it possible to provide a source for this change? Ideally something from Microsoft's docs.

This is the only credible source though.

This PR adds `*.bat` and `*.cmd` file types.

In doing so, it makes a distinction between batch files (old standard from the
MS-DOS era) and command scripts (new flavor - can operate on batch files,
although `*.cmd` is preferred for various reasons, the main one being batch
files will set `ERRORLEVEL` following inconsistent MS-DOS style rules; see
https://groups.google.com/g/microsoft.public.win2000.cmdprompt.admin/c/XHeUq8oe2wk/m/LIEViGNmkK0J#i106
for further details).
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit 601e122 into BurntSushi:master Jul 10, 2023
@mataha mataha deleted the feature/ignore/types/cmd branch July 10, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants