Add convenience functions for sorting #147
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
sort_by_key()
function like the one instd
, and asort_by_file_name()
function as a convenience for sorting by file name.My experience with directory walkers in any languages I used so far was that mostly, I either don't care about the order, or I want an order that is deterministic for the same directory content independent from the underlying system. So if I need to sort, its almost always by file name.
This was my initial motivation for adding
sort_by_key
, to makesort_by(|a, b| a.file_name().cmp(b.file_name()))
easier to write assort_by_key(|e| e.file_name())
. However, due to rust-lang/rust#34162, this does not actually compile, so I also addedsort_by_file_name()
for what I perceive as the common case.I kept
sort_by_key()
for consistency withstd
, and because there are still valid usecases for it, eg sorting by file size.