Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review sync committee rewards + penalties as PR 2453 #36

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Conversation

barnabemonnot
Copy link
Collaborator

This addresses recent changes in the eth2 specs relative to the sync committee rewards and penalties (PR#2453). Some changes:

  • Review the incentive coefficients SYNC_COMMITTEE_WEIGHT and other *_WEIGHT
  • Fix an issue with the sync committee reward computation in model/parts/incentives.py:
total_base_rewards = base_reward * number_of_validators

instead of

total_base_rewards = base_reward * number_of_validators_online
  • Separate penalties incurred from attestation duties and sync committee duties, in a new partial state update block
  • Review test checking whether rewards on a perfect network match the expected weights

@BenSchZA BenSchZA self-requested a review June 14, 2021 11:03
@BenSchZA BenSchZA added the enhancement New feature or request label Jun 14, 2021
Copy link
Collaborator

@BenSchZA BenSchZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few minor updates. Really appreciate the attention to detail!

@BenSchZA BenSchZA merged commit 9d5a70a into main Jun 14, 2021
@BenSchZA BenSchZA deleted the barnabe/sync branch June 14, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants