System directory to support experiments #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add experiments and fields Add default experiment to the save structure, update tests Linting and documentation
tab-cmd
force-pushed
the
system_directory
branch
from
6d6a093 to
1b79552
Compare
lawhead
reviewed
Oct 19, 2020
| if (os.path.isfile(full_file_name)) and '.py' in file_name: | ||
| # Copy over! | ||
| copy2(full_file_name, helper_folder_name) | ||
|
|
There was a problem hiding this comment.
When I was looking into BIDS I meant to ask if these helpers are still needed. I'm glad we're able to clean up the data.
lawhead
approved these changes
Oct 19, 2020
lawhead
reviewed
Oct 19, 2020
| parameter_location, | ||
| mode=mode, | ||
| experiment_type=exp_type, | ||
| experiment=experiment) | ||
|
|
There was a problem hiding this comment.
bci_main is passing an extra parameter to init_save_data_structure which causes an error (experiment). Sorry I didn't catch this during the review.
There was a problem hiding this comment.
Or actually, it looks like maybe this needs to be experiment_id, rather than experiment?
There was a problem hiding this comment.
yeah - it should be experiment_id. I'll re-open a PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added a system directory that contains an experiment and field registry. Updated save method to include an experiment.
Ticket
https://www.pivotaltracker.com/story/show/175193520
Contributions
.bcipy.bcipy/experiment/.bcipy/field/.bcipy/experiment/experiments.json.bcipy/field/fields.jsonhelpers/save/init_save_data_structureto include the experiment in the save structure. Defined a DEFAULT_EXPERIMENT_ID.bci_mainto include the setting of the experiment id.Test
Documentaion