Gui refactor #102
Merged
Gui refactor #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ability to add buttons and images (todo static text, combo and input boxes)
todo: resize / move assets
TODO: cleanup interface and test all features
Add fonts and update add_text method, add alert boxes, add AlertMessageType and AlertResponse, connect actions to comboboxes. Update RSVPKeyboard to use new methods
tab-cmd
commented
Oct 30, 2020
lawhead
reviewed
Oct 30, 2020
lawhead
reviewed
Oct 30, 2020
lawhead
reviewed
Oct 30, 2020
| """ | ||
| saved_users = [] | ||
| data_save_loc = self.parameters['data_save_loc'] | ||
|
|
There was a problem hiding this comment.
I just realized that the parameter_location gets updated, but the parameters never get reloaded, so this will always be the data_save_loc from the default parameters. I can fix that after this is merged.
There was a problem hiding this comment.
I added a bug ticket for this! https://www.pivotaltracker.com/story/show/175541919
lawhead
reviewed
Oct 30, 2020
lawhead
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactored base GUI to use PyQT5 instead of WxPython. This required
gui_main,BCInterfaceandRSVPKeyboardto be redone.Ticket
https://www.pivotaltracker.com/story/show/175194654
Contributions
gui_main. I kept many of the same methods and updated them to use PyQt5 functionality. I added more default methods (ex.build_assests) and abstractions (AlertResponse,AlertMessageType) to help isolate the downstream GUIS from the knowledge of PyQT5.RSVPKeyboardandBCInterfaceto use new base class and methods (build_*)Test
python bcipy/gui/gui_main.pypython bcipy/gui/BCInterface.py. Select RSVP.python bcipy/gui/mode/RSVPKeyboard.py. Input a user_id, run a task. Edit and load parameters.Documentaion