Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sklearn Deprecation Warning has been fixed. #107

Merged
merged 1 commit into from
Nov 18, 2020
Merged

sklearn Deprecation Warning has been fixed. #107

merged 1 commit into from
Nov 18, 2020

Conversation

celikbasak
Copy link
Member

Overview

sklearn: Deprecation Warning has been fixed.
sklearn requirement has been updated to scikit-learn.

Ticket

https://www.pivotaltracker.com/n/projects/2460065/stories/175322073

Contributions

  • KernelDensity class in function_density_estimation.py is imported from sklearn.neighbors instead of sklearn.neighbors.kde
  • sklearn==0.0 requirement in requirements.txt has been updated to scikit-learn==0.23.2

Test

  • The above function/class call is run within demo_density_estimation.py
  • Unit tests applied. Passed successfully.

@celikbasak
sklearn Deprecation Warning has been fixed.
683394d 
sklearn requirement has been updated to scikit-learn
@tab-cmd tab-cmd merged commit 077d98b into 1.4.3 Nov 18, 2020
@tab-cmd tab-cmd deleted the sklearn branch December 10, 2020 18:48
@tab-cmd tab-cmd mentioned this pull request Jan 20, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tab-cmd tab-cmd tab-cmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@celikbasak @tab-cmd