Field creation UI #114
Merged
Field creation UI #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawhead
reviewed
Dec 19, 2020
| @@ -96,7 +95,8 @@ def test_file_generator_end(self): | |||
| for _ in range(row_count): | |||
| next(gen) | |||
|
|
|||
| with pytest.raises(StopIteration): | |||
| with self.assertRaises(RuntimeError): | |||
There was a problem hiding this comment.
Calling next on a depleted Generator should raise a StopError exception, which is what we're explicitly testing in this situation. A RuntimeError is too general and could be the result of a different unexpected issue.
lawhead
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added a GUI for creation of new BciPy experiment fields. Small updates for ExperimentRegistry to allow creation of multiple experiments per session.
Ticket
https://www.pivotaltracker.com/story/show/175194521
Contributions
linting
Updated
gui/README: with new GUI informationREADME: with new GUI informationtest_generator: assert raises a Runtime error, which encapsulates the StopIteration. Not 100% on this one...ExperimentRegistry: to use WARN instead of INFO on check_input. To call newFieldRegistryinstead of throwing not implemented alert.gui_main: to store background_color and pass instead of logging for dropdown action.Added
FieldRegistry: GUI for creating new Fields. It should not create duplicates and require all field be input before creation.Test
BCInterface.py, create a new experiment, create a new field, close the window. Ensure new field is written and viewable in the experiment creation window. Try creating invalid fields (missing values, names already registered) and verify alerts are thrown and no data is written. Runmake test-allDocumentation