Update terms to glossary #121
Conversation
bcipy/parameters/parameters.json
Outdated
| "value": "1", | ||
| "section": "bci_config", | ||
| "readableName": "Minimum Sequence Length", | ||
| "helpTip": "The minimum number of sequences to present in spelling tasks", | ||
| "readableName": "Minimum inquiry Length", |
There was a problem hiding this comment.
You might want to capitalize 'inquiry' here for consistency.
There was a problem hiding this comment.
Nice catch - I tried to find them all but I knew a few would slip through!
|
Do we have the glossary terms defined anywhere in the code base? If not we may want to include them in one of the READMEs. Also, in our Contribution Guidelines have a bullet point to |
tab-cmd
force-pushed
the
update-terms-to-glossary
branch
from
a0767b8 to
87a13f9
Compare
tab-cmd
force-pushed
the
update-terms-to-glossary
branch
from
87a13f9 to
c0eaeb3
Compare
| @@ -71,7 +71,7 @@ make dev-install | |||
|
|
|||
| Start by running `python bcipy/gui/BCInterface.py` in your command prompt or terminal. You may also invoke the experiment directly using command line tools for bci_main.py. | |||
There was a problem hiding this comment.
Would it make sense to create a make command for this as well?
| # Schedule a sequence | ||
| rsvp.stimuli_sequence = ele_sti[counter] | ||
| # Schedule a inquiry | ||
| rsvp.stimuli_inquiry = ele_sti[counter] |
There was a problem hiding this comment.
Good change to keep it clean start with definition
| @@ -122,23 +122,23 @@ def best_case_rsvp_seq_gen(alp: list, | |||
| First element is the target, second element is the fixation | |||
| Observe that [-1] element represents the trial information | |||
Overview
Update sequence to inquiry and epoch to series
Ticket
https://www.pivotaltracker.com/story/show/176097858
Contributions
Too many to list. Replaced all usage of sequence or seq with inq. Replaced all usage of epoch or epochs with series.
Test
Documentaion