Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#177171927 ; Signal Viewer Filter #123

Merged
merged 1 commit into from
Mar 29, 2021
Merged

#177171927 ; Signal Viewer Filter #123

merged 1 commit into from
Mar 29, 2021

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Mar 12, 2021

Overview

Modified signal viewer to use filter settings defined in the params file.

Ticket

https://www.pivotaltracker.com/story/show/177171927

Contributions

  • Updated data viewer to accept the params location as a new parameter. Extracted the filter-related parameters from here to set the values when filtering the data.
  • Updated the viewer GUI to display the current configured parameters.

Test

  • Ran the demo viewer code with and without the new parameter python bcipy/gui/viewer/demo/viewer_demo.py; confirmed that the default params location was used when none was provided and that when provided the filter settings were applied.
  • Ran a calibration session with custom filtering parameters. Confirmed that the displayed settings in the viewer matched those in the custom parameters file.

@lawhead lawhead requested review from tab-cmd and AlisterD March 12, 2021 22:53
@tab-cmd tab-cmd changed the base branch from main to 1.5.1 March 29, 2021 18:40
@lawhead lawhead merged commit 74a0031 into 1.5.1 Mar 29, 2021
@lawhead lawhead deleted the signal-viewer-filter branch March 29, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants