Copy Phrase Fusion Error #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixed bug in reshaping data for Copy Phrase.
The TrialReshaper has a parameter for the sample rate (
fs) and the expected value is the sample rate of the EEG data after processing (downsampling). The calling code captured this new sample rate value after performing the default transform, but in the process mutated the existing instance value. The result of mutating this value was that for every inquiry, the data was transformed using a halved sample rate from the previous iteration.Ticket
https://www.pivotaltracker.com/story/show/178787961
Contributions
Test