InsufficientDataException fix #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… number of samples; added utility methods to raw_data module to assist in debugging.
tab-cmd
approved these changes
Oct 4, 2021
| @@ -13,6 +13,7 @@ | |||
| from bcipy.acquisition.protocols.lsl.lsl_recorder import LslRecordingThread | |||
| from bcipy.acquisition.record import Record | |||
| from bcipy.helpers.clock import Clock | |||
| from bcipy.gui.viewer.ring_buffer import RingBuffer | |||
There was a problem hiding this comment.
We should move this outside of gui... not sure the best place
There was a problem hiding this comment.
Agreed. I'll create a followup ticket for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
During execution of the Copy Phrase task, the
get_data_for_decisionfunction in the task helper would sometimes throw anInsufficientDataExceptionafter querying the acquisition client for data. The client had enough data in the desired range but the timestamp alignment was slightly off. The query was modified to explicitly ask for a given number of samples.Ticket
https://www.pivotaltracker.com/story/show/179644506
Contributions
Test