Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the triggers.txt file output by the Copy Phrase task to correctly label targets.
The error was in the calculation for the next target in the helper function. This method took a parameter for the copy_phrase and one for the typed_letters and used this information to determine the target. However, prior to a recent refactor, the spelled text was updated before writing triggers. In the current code the triggers are written prior to the decision that updates spelled text. So the code was using the last letter of the spelled text rather than the next un-spelled letter.
Given the potential ambiguity here, I refactored the code to make the target_symbol a parameter. This was already being calculated by the Task for use in the session data.
Ticket
https://www.pivotaltracker.com/story/show/179811273
Contributions
Test