Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#181038299 ; acquisition module docs #217

Merged
merged 3 commits into from
Apr 28, 2022
Merged

#181038299 ; acquisition module docs #217

merged 3 commits into from
Apr 28, 2022

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Apr 28, 2022

Overview

Updated documentation for the acquisition module.

Ticket

https://www.pivotaltracker.com/story/show/181038299

Contributions

  • Updated the documentation for the acquisition module to reflect the multi-modal work and new LSL client.

Discussion

I decided to defer the removal of the v1 DataAcquisitionClient and related classes to rc2, since it will require additional system testing to ensure that those classes are not being used (ex. in viewer related code, demos, tests, etc). For the meantime I updated the documentation. I will create a followup ticket to remove the deprecated code.

@lawhead lawhead requested a review from tab-cmd April 28, 2022 22:14

## Supported Devices

The acquisition module connects with hardware devices using the Lab Streaming Layer (LSL) library. Each device should provide its own LSL driver / application to use for streaming data. The streamer should be started prior to running the `bcipy` application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples could be helpful here and/or a link to an app!

Apps: https://labstreaminglayer.readthedocs.io/info/supported_devices.html
If your device does not have a supported app see https://labstreaminglayer.readthedocs.io/dev/app_build.html

@lawhead lawhead merged commit 2564fd2 into 1.5.1 Apr 28, 2022
@lawhead lawhead deleted the acq_docs branch April 28, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants