Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent GUI Double Clicks #218

Merged
merged 1 commit into from
May 6, 2022
Merged

Prevent GUI Double Clicks #218

merged 1 commit into from
May 6, 2022

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented May 6, 2022

Overview

Added a BCIGui timer that is used in BCInterface to prevent double-clicking behavior.

Ticket

Contributions

  • gui.main.py: add timer
  • gui.gui_main.py --> gui.main.py: refactor to match other modules while in release canditate
  • gui.BCInterfacy.py: added an action_disabled and _disable_action methods to create a timer that would disable actions for a time (self.timeout). Add the action_disabled check to all clickable events in the GUI.

Test

  • make test-all
  • Run the BCInterface.py GUI and try double-clicking buttons. Ensure that the defined timeout actions are possible again after the timeout.

Documentation

  • Are documentation updates required? In-line, README, or documentation? Verify the updates you did here. N/A

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? I will once approved! :D

@tab-cmd tab-cmd requested a review from lawhead May 6, 2022 19:13
@tab-cmd tab-cmd merged commit 7bed5ee into 2.0.0rc2 May 6, 2022
@tab-cmd tab-cmd deleted the gui_double_clicks branch May 31, 2022 18:08
@tab-cmd tab-cmd mentioned this pull request Sep 26, 2022
tab-cmd added a commit that referenced this pull request Sep 26, 2022
tab-cmd added a commit that referenced this pull request Oct 3, 2022
* add timer to prevent double clicking (#218)

* #181963356 ; added better alerting to inform users when fake data mode is on

* Added changelog entry

* Refactoring to reduce duplication

* #182040775 ; option to summarize session at the end of a copy phrase task

* Update README.md

High level GPT2 documentation added, word level prediction described, contact information added

* Matrix Display Fixes (#221)

* fixes bug with last stimuli lagging in matrix calibration, added entire grid flash before each inquiry

* Address PR comment + cleanup

Co-authored-by: Tab Memmott <[email protected]>

* Refactored session helper to generate spreadsheets without first creating a sqlite database

* ERP plotting improvements and MNE data support (#220)

* #182005453 ; added parameter for signal model path; updated initialization code to use this for typing tasks

* #182406904 ; Fix bug when generating a spreadsheet from active session data

* [Bug fix] Two presses needed to start copy phrase (#225)

* Documentation and formatting

* #182200897 ; check for internet connection and confirm before proceeding with the session

* Added logging for GPU information, if available

* Whitespace fix

* Added changes

* Move session validation to validate module; update internet connectivity test to work with VPN

* #182106570 ; added functionality for configuration channel specifications for a given device.

* Added a test mock to prevent a GUI interaction during testing

* Fix test issue by switching to a different acquisition client for mocking

* use a better default timeout (#228)

* #182776686 ; prevent widgets scrolling on parameters form

* Jitter (#233)

Jitter for calibration + parameter. copy phrase ip

cleanup stimuli tests

* User ID reset bug and cleanup (#235)

User id reset fix

* Add support for Tobii Nano (#234)

* Add support for Tobii Nano

* address PR feedback

* update changelog

* added ssvep to cvep method (#232)

Co-authored-by: Aida Fakhry <[email protected]>
Co-authored-by: Tab Memmott <[email protected]>

* #183037159 ; alert when using battery power

* Better documentation on return values and potential impacts

* VEP Display (#237)

* upgrade psychopy  (#239)

* ERP viz demo fix (#240)

* #175193924 infrastructure for changed parameters ; #183134229 Fixed issue with params_form rounding some float values ; #183133776  allow static offset to be input with more precision

* Remove unneeded parameters  (#241)

* signal model loaded log (#244)

better signal model logging

* Devices config update && BciPy running outside of root (#242)

* Refactor param changes GUI to use a scroll area for displaying a large number of changes

* Refinements; parameters changes start out collapsed if empty; minor refactorings

* #182408060 ; Ensure that spelled text is provided to the language model when using fake data

* Export the device used as a useable config file (#247)

* Convert: add BDF support and fix static offset bug (#246)

* #182031676 ; remove TCP-based acquisition code

* Added PR number to changelog

* Added function type information; better string representations of channel specs and device specs; removed unused code in tests

* Updated max_buffer_len parameter name for lsl_client

* fix rebase issue in parameters module

* Bug fixes: jitter, offline analysis, task complete alerting  (#250)

* Matrix Bug: fix for scp flashing (#252)

* Matrix documentation (#253)

Co-authored-by: lawhead <[email protected]>
Co-authored-by: Shijia Liu <[email protected]>
Co-authored-by: jcgangemi1 <[email protected]>
Co-authored-by: AidaFakhry <[email protected]>
Co-authored-by: Aida Fakhry <[email protected]>
Co-authored-by: Basak Celik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants