#181963356 ; fake data alerting #219
Conversation
bcipy/main.py
Outdated
| @@ -95,6 +100,7 @@ def execute_task(task: TaskType, parameters: dict, save_folder: str) -> bool: | |||
| language_model = None | |||
|
|
|||
| fake = parameters['fake_data'] | |||
| log.info(f"fake data is {'on' if fake else 'off'}") | |||
There was a problem hiding this comment.
It might be helpful to know what fake data means... f"/n fake data is {'on. generating fake data for ' if fake else 'off. attempting to acquire data from'} {device_name}..."
and we could log in the case of fake data and signal model below: f"fake data is on, all decisions will be faked. no signal model required". We talked about making more nuianced fake or simulated behaviour, but this message would alert the user to the current behaviour.
There was a problem hiding this comment.
Good suggestion. I moved the logging to the acquisition helper and added more detail. I would like to defer additional logging for fake_decisions for the other ticket.
| from PyQt5.QtWidgets import QApplication, QMessageBox | ||
|
|
||
|
|
||
| def confirm(message: str) -> bool: |
There was a problem hiding this comment.
Some duplicate functionality and enums exist in gui_main
It may be useful to use the enums or factor this out of BCIGui to be used elsewhere.
There was a problem hiding this comment.
Good callout. I factored out the code for constructing a MessageBox into its own function in GUI/main that's now used in both BCIGui and here. They each call the resulting message box in slightly different ways and have separate use cases, so I think it still makes sense for them to be distinct, but now this module uses functionality provided by the main module.
Overview
Added better alerting to inform users when fake data mode is on.
Ticket
https://www.pivotaltracker.com/story/show/181963356
Contributions
Test