Internet connection alert #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tab-cmd
approved these changes
Jun 17, 2022
bcipy/helpers/system_utils.py
Outdated
| REMOTE_SERVER = "https://github.com/CAMBI-tech/BciPy/" | ||
|
|
||
|
|
||
| def is_connected(hostname: str = "one.one.one.one", port=80) -> bool: |
There was a problem hiding this comment.
REMOTE_SERVER could be the default here
There was a problem hiding this comment.
Turns out this doesn't work if I'm on OHSU's VPN and it thought I was not on the internet. I updated this to use the "1.1.1.1" DNS resolver and it works both on and off VPN.
bcipy/main.py
Outdated
| @@ -22,6 +22,31 @@ | |||
| log = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def preconditions_ok(parameters) -> bool: | |||
There was a problem hiding this comment.
What do you think of moving this to helpers/validate.py. We use a similar pattern for validating experiments. Another option for the method name: validate_bcipy_session or similar to be more explicit
…ity test to work with VPN
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added an alert when the user's computer has an active internet connection.
Ticket
https://www.pivotaltracker.com/story/show/182200897
Contributions
Test