#183037159 ; alert when using battery power #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tab-cmd
approved these changes
Aug 29, 2022
bcipy/helpers/system_utils.py
Outdated
| @@ -43,6 +43,12 @@ def is_connected(hostname: str = "1.1.1.1", port=80) -> bool: | |||
| return False | |||
|
|
|||
|
|
|||
| def is_battery_powered() -> bool: | |||
| """Check if this current computer is a laptop currently using its battery.""" | |||
There was a problem hiding this comment.
Some more context may be useful! Returns True if the computer is currently running on battery power. This can impact the performance of hardware (ex. GPU) needed for BciPy operation by entering power saving operations.
| @@ -25,7 +26,8 @@ def validate_bcipy_session(parameters: dict) -> bool: | |||
| True if it's okay to continue, otherwise False | |||
| """ | |||
| possible_alerts = [(parameters['fake_data'], '* Fake data is on.'), | |||
| (is_connected(), '* Internet is on.')] | |||
| (is_connected(), '* Internet is on.'), | |||
| (is_battery_powered(), '* Operating on battery power')] | |||
There was a problem hiding this comment.
This pattern is really coming in handy. It's clean 😎
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added an alert to check for battery power before performing a task.
Ticket
https://www.pivotaltracker.com/story/show/183037159
Contributions
Test