Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#179846837 ; user editable parameters #256

Merged
merged 4 commits into from
Nov 30, 2022
Merged

#179846837 ; user editable parameters #256

merged 4 commits into from
Nov 30, 2022

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Oct 21, 2022 •
edited
Loading

Overview

Params GUI change so that only parameters with a value in the 'section' attribute are user-editable.

Ticket

https://www.pivotaltracker.com/story/show/179846837

Contributions

  • Updated params_form to only allow user to edit parameters with a section.

Test

  • Tested editing a copy of parameters.json where the section was set to blank for a number of fields. Confirmed that those fields did not appear in the GUI, but were retained when the file was saved or saved as another file.
  • Confirmed that editing a normal, unmodified parameters file was unchanged and that the user could view and edit all parameters.

@lawhead lawhead requested a review from tab-cmd October 21, 2022 22:50
@lawhead lawhead merged commit 5d83462 into 2.0.0rc3 Nov 30, 2022
@lawhead lawhead deleted the uneditable-params branch November 30, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tab-cmd tab-cmd tab-cmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawhead @tab-cmd