Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ERP figures after bcipy sessions #260

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Jan 9, 2023

Overview

Added a visualize_session_data method to helpers/visualization.py. This method is now used in main.py with the boolean visualize on bci_main. This results in an ERP image generated after each session (fake, calibration, copy phrase, etc.). It will fail to generate an image if no target or nontarget labels are found.

Ticket

Ticket

Contributions

  • helpers/visualization.py: new method visualize_session_data that leverages the existing visualize_erp function.
  • offline_analysis.py: by default, do not save the figures after training; assume this will happen after a session. This is helpful to know what channels etc., to include before training.
  • main.py: update bci_main to include a visualize boolean. Using the new visualize_session_data method, an ERP image is generated and saved to the session folder.

Test

  • Make test-all
  • Make integration-test
  • Run bcipy and ensure figures generate after the session.

Documentation

  • Are documentation updates required? In-line, README, or documentation? Updated docstrings where appropriate.

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? Yes!

@tab-cmd tab-cmd requested review from celikbasak and lawhead January 9, 2023 22:29
@tab-cmd tab-cmd merged commit ec99f3d into 2.0.0rc3 Jan 13, 2023
@tab-cmd tab-cmd deleted the generate_figures branch January 13, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants