Device channel specs #266
Merged
Device channel specs #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses from devices.json and updated the code to use the primary device names
tab-cmd
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Looks great! This can be another ticket, but we should document these parameter files (devices.json and parameters.json) in the README and what changing/adding things to them might do. We mention things briefly in the core modules section, but I'm unsure I would understand what to do having read just that. Thanks for the updates
| { "name": "F7", "label": "F7", "units": "microvolts", "type": "EEG" }, | ||
| { "name": "PO8", "label": "PO8", "units": "microvolts", "type": "EEG" }, | ||
| { "name": "PO7", "label": "PO7", "units": "microvolts", "type": "EEG" }, | ||
| { "name": "Oz", "label": "Oz", "units": "microvolts", "type": "EEG" }, |
There was a problem hiding this comment.
Is that how LSL outputs it? "microvolts"? I'm okay with either but usually, I only see the abbreviation.
There was a problem hiding this comment.
Yeah, the units that come across depend on what the adapter application sends. In this case, it's dsi2lsl that's writing these metadata values. See:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Set channel spec information in devices.json. Removed aliases.
Ticket
https://www.pivotaltracker.com/story/show/182849439
Contributions
Test