Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP calibration #267

Merged
merged 3 commits into from
Feb 27, 2023
Merged

IP calibration #267

merged 3 commits into from
Feb 27, 2023

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Feb 22, 2023

Overview

Add inquiry preview feature to RSVP calibration.

Ticket

Contributions

  • RSVP Calibration: add inquiry preview properties to the display init
  • RSVP Display: add preview_calibration arg to do_inquiry method

Test

  • make test-all
  • bcipy --task "RSVP Calibration" with and without preview_inquiry enabled
  • bcipy --task "RSVP Copy Phrase" to make sure nothing impacted with the update

Documentation

  • Are documentation updates required? In-line, README, or documentation? added docstrings and updated where needed.

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? yes!

@tab-cmd tab-cmd requested a review from lawhead February 25, 2023 19:25
@tab-cmd tab-cmd merged commit 5c615be into 2.0.0rc3 Feb 27, 2023
@tab-cmd tab-cmd deleted the IP_calibration branch December 10, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawhead lawhead lawhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tab-cmd @lawhead