Filter updates and small fixes to offline analysis #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter changes, catch bad path errors on load, update integration tests with a valid device name (DSI --> DSI-24)
lawhead
approved these changes
Mar 22, 2023
celikbasak
approved these changes
Mar 24, 2023
tab-cmd
added a commit
that referenced
this pull request
Apr 17, 2023
Offline analysis updates Filter changes, catch bad path errors on load, update integration tests with a valid device name (DSI --> DSI-24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update the BciPy default filter to sosfiltfilt, which will perform better than sosfilt. Update integration tests to use valid device name (DSI-24). Update load method to catch file not found error stacktrace and alert user.
Ticket
Link a pivotal ticket here
Contributions
signal/process/filter.py: update to usesosfiltfilthttps://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.sosfiltfilt.htmlhelpers/raw_data.py: update load to catch FileNotFoundError and return BciPyCoreException describing the issuesignal/test/model/inputupdate the raw_data.csv file header with a registered device nameTest
Make test-allDocumentation
Changelog