Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross Validation Fixes, Integration Test updates and CHAGELOG updates #271

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Cross Validation Fixes, Integration Test updates and CHAGELOG updates #271

merged 4 commits into from
Mar 27, 2023

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Mar 24, 2023

Overview

Update code changed with @celikbasak to run varied offline analyses (varied # of trials, trial_length, etc).

Ticket

Contributions

  • cross_validation: update to the loop creating k-folds to avoid an extra empty fold
  • offline_analysis: update the train/test split. Updated the integration tests.

Test

  • make test-all
  • pytest --mpl -k "slow"
  • Run offline analysis on known data with no changes

Documentation

  • Are documentation updates required? In-line, README, or documentation? Verify the updates you did here. N/a

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? Yes, and I added some we had forgotten about!

celikbasak
celikbasak approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@celikbasak celikbasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you Tab!

@tab-cmd tab-cmd merged commit 6d81f83 into 2.0.0rc3 Mar 27, 2023
@tab-cmd tab-cmd deleted the cv_fixes branch March 27, 2023 20:32
tab-cmd added a commit that referenced this pull request Apr 17, 2023
@tab-cmd
Cross Validation Fixes, Integration Test updates and CHAGELOG updates (…
aed6203 
…#271)

* update offline analysis to perform the correct split

* Update cross validation logic to prevent an empty fold

* Update CHANGELOG and integration test assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celikbasak celikbasak celikbasak approved these changes

@lawhead lawhead lawhead approved these changes

@danielpklee danielpklee Awaiting requested review from danielpklee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tab-cmd @lawhead @celikbasak