Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New default Wearable Sensing channels, upgrades to permit alpha analyses, cleanup #279

Merged
merged 17 commits into from
Apr 20, 2023

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Apr 16, 2023

Overview

Upgrades to support alpha analyses post-2.0. Integration of CWT, MockPCA, documentation cleanups, and tests. Update the default channels. Output channels selected for analysis in offline_analysis.

Ticket

https://www.pivotaltracker.com/story/show/184656331

Contributions

  • decomposition: add continuous_wavelet_transform, add error handling to power_spectral_density.
  • helpers/exceptions: moved signal exception to this location
  • stimuli.py: update extract trials to accept a prestimulus argument. Refactor to assume all inputs are downsampled. Add update_inquiry_timing to help update timing in offline_analysis.
  • parameters/devices.json: update default channels to those proposed by the clinical team
  • requirements.txt: update scikit-learn to latest and add pywavelets
  • signal/tests/model/integration_test_expected_output: generated new output using the updated channels

Test

  • make test-all
  • pytest --mpl -k "slow"

Documentation

  • Are documentation updates required? In-line, README, or documentation? Verify the updates you did here. Updated docstring and READMEs where applicable.

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? TODO

@tab-cmd tab-cmd requested a review from lawhead April 17, 2023 22:30
@tab-cmd tab-cmd merged commit bda9a8e into 2.0.0rc3 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants