Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jitter to matrix and time tests #281

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Add jitter to matrix and time tests #281

merged 1 commit into from
Apr 18, 2023

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Apr 16, 2023

Overview

Add stim_jitter parameter to Matrix. Add jitter to time test verifications to help in testing different stimuli configurations.

Ticket

https://www.pivotaltracker.com/story/show/183548761

Contributions

  • matrix/calibration.py: add reference to stim_jitter, apply to generate stimuli method
  • timing_verification.py: added jittered timing to both RSVP and Matrix time tests

Test

  • make test-all
  • bcipy --task "Matrix Time Test Calibration" -nv
  • bcipy --task "RSVP Time Test Calibration" -nv

Documentation

  • Are documentation updates required? In-line, README, or documentation? Verify the updates you did here. N/a

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? TODO

@tab-cmd tab-cmd requested review from lawhead and danielpklee April 17, 2023 22:31
@tab-cmd tab-cmd merged commit 978c750 into 2.0.0rc3 Apr 18, 2023
@tab-cmd tab-cmd deleted the jitter_time_test branch April 18, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawhead lawhead lawhead approved these changes

@danielpklee danielpklee Awaiting requested review from danielpklee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tab-cmd @lawhead