Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server metadata #282

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Server metadata #282

merged 2 commits into from
Apr 25, 2023

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Apr 21, 2023

Overview

Refinements to LSL server to use the device ChannelSpec information for generating metadata.

Ticket

https://www.pivotaltracker.com/story/show/179542651

Contributions

  • Updated lsl_server
  • Updated code for discovering devices to provide a timeout if the device is not available.

Test

  • Started a demo Eyetracker server; used pylsl to inspect the stream metadata to confirm that it had the correct shape and values.

@lawhead lawhead requested a review from tab-cmd April 21, 2023 00:54
@lawhead lawhead changed the base branch from main to 2.0.0rc3 April 21, 2023 00:54
Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGELOG before merging. I will release rc3 after that! Thanks

@@ -300,7 +300,7 @@ def discover_device_spec(content_type: str) -> DeviceSpec:
"""Finds the first LSL stream with the given content type and creates a
device spec from the stream's metadata."""
log.info(f"Waiting for {content_type} data to be streamed over LSL.")
streams = resolve_stream('type', content_type)
streams = resolve_byprop('type', content_type, timeout=5.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@lawhead lawhead merged commit 520c078 into 2.0.0rc3 Apr 25, 2023
@lawhead lawhead deleted the server-metadata branch April 25, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants