Home use testing: screen refresh alert and offline analysis updates #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Tested release candidate in a variety of home use scenarios. One issue observed in using a secondary usb-c monitor was if a disconnect occurs or the battery runs out, the primary monitor refresh rate may change to default settings. This can be configured per display arrangement to some degree in Windows; however, to prevent issues in the future and add some awareness of the monitor requirements, I've added an alert for low monitor refresh rates. In the future, we might also consider a consistent frame rate check using PsychoPy to determine monitor stability.
Ticket
https://www.pivotaltracker.com/story/show/184589205
Contributions
system_utils.py
: update the screen properties method to return the refresh rate, addis_screen_refresh_ok
check.validate.py
: update validate_bcipy_session to include a check for screen refreshoffset_anaysis.py
: update to script with documentation and to support future factoring into codebaseTest
Documentation
Changelog