Calib all symbols #287
Merged
Calib all symbols #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istribution. Factored out calculation of random_target_positions into its own function which could be thoroughly tested. Added unit tests for new function
…ries. Refactored to ensure that symbols were presented as targets with equal frequency
tab-cmd
approved these changes
Jul 28, 2023
| target_indexes = distributed_target_positions(stim_number, stim_length, nontarget_inquiries) | ||
| if timing is None: | ||
| timing = [0.5, 1, 0.2] | ||
| if color is None: |
There was a problem hiding this comment.
I'd be okay making these required inputs. I don't think we gain much from having these defaults.
There was a problem hiding this comment.
I think the main advantage is in testing and demos when we primarily care about the symbols.
celikbasak
reviewed
Aug 1, 2023
bcipy/helpers/stimuli.py
Outdated
| stim_order: StimuliOrder = StimuliOrder.RANDOM, | ||
| target_positions: TargetPositions = TargetPositions.RANDOM, | ||
| nontarget_inquiries: int = 10, | ||
| percentage_without_target: int = 10, |
There was a problem hiding this comment.
Based on our previous discussions maybe we can scrap this number and set the default as 0?
celikbasak
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactored stimuli generation to ensure that all symbols are shown in a calibration.
Ticket
https://www.pivotaltracker.com/story/show/185235958
Contributions
Test