Dynamic Trial Window Selection #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the older signal models cannot be used on a newer codebase... remove unusable load methods after refactor
lawhead
approved these changes
Aug 24, 2023
| static_offset = parameters.get("static_trigger_offset") | ||
|
|
||
| raw_data = load_raw_data(Path(session_path, f'{RAW_DATA_FILENAME}.csv')) | ||
| channels = raw_data.channels | ||
| sample_rate = raw_data.sample_rate | ||
|
|
||
| transform_params = parameters.instantiate(ERPTransformParams) |
There was a problem hiding this comment.
Good catch. I knew I was missing this somewhere.
| @@ -618,7 +622,7 @@ | |||
| "type": "int" | |||
| }, | |||
| "lang_model_type": { | |||
| "value": "MIXTURE", | |||
| "value": "UNIFORM", | |||
There was a problem hiding this comment.
Looks like we had the same idea here. :)
| @@ -171,12 +171,14 @@ def predict_proba(self, data: np.array) -> np.array: | |||
| posterior = np.exp(np.stack([log_post_0, log_post_1], axis=-1)) | |||
| return posterior | |||
|
|
|||
| def save(self, path: Path): | |||
| def save(self, path: Path) -> None: | |||
There was a problem hiding this comment.
We may want to just delete these save and load methods to avoid confusion. The save module should be used now as it saves the entire class and uses a specific pickle version.
There was a problem hiding this comment.
These are required as part of the base class, so I will hold off for now!
tab-cmd
commented
Aug 24, 2023
scripts/python/replay_session.py
Outdated
| nontargets_with_old_model, | ||
| args.outdir) | ||
|
|
||
| breakpoint() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Using the newly added range type parameter, this PR adds the functionality to select different trial windows after stimuli presentions for modeling, online task use, and visualization.
Ticket
https://www.pivotaltracker.com/story/show/182151298
Contributions
Test
make test-allDocumentation
Changelog