Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix row spacing #298

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Matrix row spacing #298

merged 3 commits into from
Oct 31, 2023

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Oct 11, 2023

Overview

Fixed computed positions for matrix layout to display equally spaced regardless of the Window's aspect ratio. Rows and columns should appear the same distance apart.

Ticket

Link a pivotal ticket here

Contributions

  • Updated the matrix layout module to account for the window aspect ration when computing spacing. Also added a parameter for max_spacing to allow.
  • Added demo for visualizing different matrix layout parameters.
  • Added code to log the position of each symbol stim in the matrix display

Test

  • Ran all unit tests
  • Ran relevant demos

@lawhead lawhead requested a review from tab-cmd October 11, 2023 01:13
@lawhead
Copy link
Collaborator Author

lawhead commented Oct 11, 2023

Looks like I have some test errors to resolve. Sorry about that.

@lawhead lawhead requested a review from celikbasak October 16, 2023 17:25
@lawhead lawhead merged commit 76268f6 into 2.0.0rc4 Oct 31, 2023
@lawhead lawhead deleted the matrix-row-spacing branch October 31, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants