Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests to rehsapers #302

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Adds tests to rehsapers #302

merged 7 commits into from
Nov 14, 2023

Conversation

Carsonthemonkey
Copy link
Collaborator

Overview

Add unit tests to reshapers to increase coverage.

Ticket

Inquiry and Trial reshaping test

Contributions

  • test_stimuli: added to reshaper tests

Test

  • make test-all

Documentation

  • Are documentation updates required? In-line, README, or documentation? Verify the updates you did here.

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? Not yet.

@tab-cmd tab-cmd self-requested a review November 14, 2023 18:42
Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address small variable name, otherwise looks good!

"""Test best_case_rsvp_inq_gen throws error when passed invalid alp shape"""
alp = ['a', 'b', 'c', 'd']
session_stimuli = [0.1, 0.1, 0.1, 0.2, 0.2, 0.1, 0.2]
n = 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a variable name

@tab-cmd tab-cmd merged commit c6bce92 into 2.0.0rc4 Nov 14, 2023
6 checks passed
@tab-cmd tab-cmd deleted the reshaper_testing branch November 14, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants