Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multimodal offline analysis updates, bug fixes #305

Closed
wants to merge 2 commits into from
Closed

Multimodal offline analysis updates, bug fixes #305

wants to merge 2 commits into from

Conversation

celikbasak
Copy link
Member

Overview

Updates and bug fixes after the first multimodal PR merge.

Ticket

Pivotal ticket

Contributions

  • Ensured that the offline analysis runs without error for both EEG and Gaze data.
  • Bug that prevents gaze data visualization is fixed.
  • Clean-up of unnecessary code in offline analysis. All functions are moved into bcipy/signal/model module.
  • Two gaze models (individual and centralized) are completed and made ready for analysis.

Test

  • Unit tests completed

Documentation

  • Documentation pending!

Changelog

  • CHANGELOG.md updated

@celikbasak celikbasak requested review from tab-cmd and lawhead December 1, 2023 00:45
tab-cmd
tab-cmd approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@tab-cmd tab-cmd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates! Do the integration tests still pass? Should we write one for the Gaze Model? Don't worry about the Windows build failures. I found a fix.

bcipy/helpers/stimuli.py Show resolved Hide resolved
bcipy/signal/model/gaussian_mixture/gaussian_mixture.py Show resolved Hide resolved
bcipy/signal/model/gaussian_mixture/gaussian_mixture.py Show resolved Hide resolved
bcipy/signal/model/offline_analysis.py Show resolved Hide resolved
bcipy/signal/model/offline_analysis.py Show resolved Hide resolved
lawhead
lawhead approved these changes Dec 19, 2023
View reviewed changes
bcipy/helpers/stimuli.py Show resolved Hide resolved
bcipy/helpers/stimuli.py Show resolved Hide resolved
@tab-cmd tab-cmd closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tab-cmd tab-cmd tab-cmd approved these changes

@lawhead lawhead lawhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@celikbasak @lawhead @tab-cmd