-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEP calibration session data #322
Conversation
…on (per session or per inquiry)
…o record details about the setup and the box of interest for each inquiry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I sent the output to @celikbasak to check it had all the information needed for our models.
Here are my notes for things to address in future PRs:
- I wasn't able to get the time spent output in the session.json on my machine.
- I encountered a weird double animation during inquiries. I'll send you a screen capture on Discord (too large for GitHub).
- Fake data capability. I ended up hardcoding my frame rate and hacking in the fake parameter from start_task. We might consider adding that feature to help with development. This may be related to the double animation I experienced though!
stim_props = VEPStimuliProperties( | ||
stim_font=parameters['font'], | ||
stim_pos=box_config.positions, | ||
stim_height=0.1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a good class variable so we can change it with task parameters as needed
The double animation happens if the frame rate is incorrect. There is a VEP Display parameter for manually setting the frame rate, which overrides the psychopy computed value, which doesn't seem to work on my M2 Mac. You can try setting this value and see if that fixes it for you. I had to set this to 120hz even though I have my Display settings set to 60hz. I set this in the VEP calibration module, but I agree that exposing this as a parameter might be useful. I'm not sure I'm computing the time_spent. I'll double-check that and add it to this PR. |
Okay! @celikbasak said this should be enough to train VEP models. We may find better ways to organize/make this available online, but I think it's worth waiting to test out / encounter pain points. |
Overview
Added session.json output for VEP Calibration task to capture data needed for creating a model.
Ticket
https://www.pivotaltracker.com/story/show/186522989
Contributions
Test