GitHub actions MacOS build fix #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce redundant code and ensure the install process is consistant
as suggested [here](DeepLabCut/DeepLabCut#2342)
This reduces code duplication and ensures that github actions reflect build process
This reverts commit db0e868.
This reverts commit 45e1927.
This reverts commit 2d6c43c.
tab-cmd
approved these changes
May 23, 2024
| @@ -36,13 +36,10 @@ jobs: | |||
| sudo apt-get install libsndfile* | |||
| sudo apt-get install xvfb | |||
| python -m pip install --upgrade pip | |||
| pip install kenlm==0.1 --global-option="--max_order=12" | |||
| pip install psychopy==2023.2.1 --no-deps | |||
| pip install attrdict3 | |||
There was a problem hiding this comment.
We could potentially add this in another install script and have the pip upgrade command as part of dev install
| @@ -119,24 +113,21 @@ jobs: | |||
| python-version: ${{ matrix.python-version }} | |||
| - name: update pip & install custom dependencies | |||
| run: | | |||
| sh scripts/shell/m2chip_install.sh | |||
| brew install labstreaminglayer/tap/lsl | |||
There was a problem hiding this comment.
Is this already part of the dev script?
| tqdm==4.62.2 | ||
| tables==3.7.0 |
There was a problem hiding this comment.
Was this missing from all builds or just Mac?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes issue where macOS builds on the GitHub actions would fail, and refactors GitHub actions to use makefile.
Ticket
Pivotal ticket
Contributions
Test
Documentation
Updated comment in
m2chip_install.shto indicate it has been tested on M3. other than that, the changes don't require additional documentationChangelog